Skip to content

Commit

Permalink
test(bigquery): import googlenotfound error to handle overlapping tab…
Browse files Browse the repository at this point in the history
…le name test
  • Loading branch information
cpcloud committed Aug 4, 2024
1 parent 2bb92d9 commit 907227e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ibis/backends/tests/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@

try:
from google.api_core.exceptions import BadRequest as GoogleBadRequest
from google.api_core.exceptions import NotFound as GoogleNotFound
except ImportError:
GoogleBadRequest = None
GoogleBadRequest = GoogleNotFound = None

try:
from polars.exceptions import ColumnNotFoundError as PolarsColumnNotFoundError
Expand Down
2 changes: 2 additions & 0 deletions ibis/backends/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from ibis.backends.tests.errors import (
ClickHouseDatabaseError,
ExaQueryError,
GoogleNotFound,
ImpalaHiveServer2Error,
MySQLProgrammingError,
OracleDatabaseError,
Expand Down Expand Up @@ -1659,6 +1660,7 @@ def test_no_accidental_cross_database_table_load(con_create_database):
MySQLProgrammingError,
ExaQueryError,
SnowflakeProgrammingError,
GoogleNotFound,
),
),
# datafusion really needs to get their exception story in order
Expand Down

0 comments on commit 907227e

Please sign in to comment.