Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): allow temp=None #10289

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Oct 9, 2024

Fixes an issue where temp was not allowed to be None like our other backends

@cpcloud cpcloud added this to the 10.0 milestone Oct 9, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend labels Oct 9, 2024
@cpcloud cpcloud force-pushed the fix-mssql-temp branch 2 times, most recently from db7cb57 to 696902a Compare October 9, 2024 12:17
@github-actions github-actions bot added the tests Issues or PRs related to tests label Oct 9, 2024
@cpcloud cpcloud merged commit ea1c179 into ibis-project:main Oct 9, 2024
77 checks passed
@cpcloud cpcloud deleted the fix-mssql-temp branch October 9, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant