feat: add py.typed to allow mypy to type check packages that use ibis #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In checking a package I am working on, I noticed the BaseBackend.table() method was missing, and it appears this method should be available for all backends, so I added an abc method for it.
cpcloud
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In checking a package I am working on, I noticed the BaseBackend.table() method was missing, and it appears this method should be available for all backends, so I added an abc method for it.
Note: Since Ibis is using
poetry, I don't think anything else is needed to include this file. See: https://jugmac00.github.io/blog/bite-my-shiny-type-annotated-library/#poetryFixes #5279