Notify on logout #122
Merged
Notify on logout #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 29, 2018 17:55
added 2 commits
November 11, 2018 09:53
added 2 commits
November 11, 2018 11:10
rotembr
reviewed
Nov 14, 2018
| maven { | ||
| url 'https://maven.google.com/' | ||
| name 'Google' | ||
| } | ||
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:3.1.2' | ||
| classpath "com.android.tools.build:gradle:3.1.1" |
There was a problem hiding this comment.
can you check that v 3.1.2 works for you? It did not work for me and for Vitali. The continuous build also failed.
rotembr
reviewed
Nov 14, 2018
|
|
||
| private static final String OAUTH_ACTIVITY_LOGGING_PATH = "/activity_logging"; | ||
| private static final String ID_KEY = "id_token"; | ||
| private static final String ACTIVITY_KEY = "eventName"; |
There was a problem hiding this comment.
can we name it
EVENT_NAME and
ID_TOKEN ?
There was a problem hiding this comment.
changed to EVENT_NAME_KEY, ID_TOKEN_KEY
rotembr
reviewed
Nov 14, 2018
|
|
||
| ResponseListener resListener = new ResponseListener() { | ||
| @Override | ||
| public void onSuccess(Response response) { |
rotembr
reviewed
Nov 14, 2018
| } | ||
| @Override | ||
| public void onFailure(Response response, Throwable t, JSONObject extendedInfo) { | ||
| logger.debug("Failed to submit logging request"); |
There was a problem hiding this comment.
should it be debug ? why not error?
rotembr
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.