Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fn microsoft security graph 1.1.1 #71

Conversation

lmahoney1
Copy link

@lmahoney1 lmahoney1 commented Apr 20, 2021

Description

**duplicate of PR #67 ** I made 67 with my other github account, I am supposed to be using this github account going forward.

Changed the variable the CTS uses to determine if a result from urlscan.io is malicious or not.

Motivation and Context

Fixes #66

How Has This Been Tested?

Submitted the url mentioned in the issue and the CTS returns a hit.

Checklist:

  • I have added a Signed-off-by
  • Either no new documentation is required by this change, OR I added new documentation
  • Either no new tests are required by this change, OR I added new tests
  • I have run pep8 and pylint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.

Signed-off-by: Liam Mahoney [email protected]

@LiamMahoney LiamMahoney mentioned this pull request Apr 20, 2021
4 tasks
@annmarien
Copy link

Hi Liam

We have added scope in the 1.2.0 release of fn_microsoft_security_graph now on he App Exchange.
Thanks for your input.

@annmarien annmarien closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fn_microsoft_security_graph unable to connect to gov cloud
2 participants