Skip to content
This repository has been archived by the owner on Oct 16, 2021. It is now read-only.

Commit

Permalink
Build configuration changes to support s390 / zLinux
Browse files Browse the repository at this point in the history
Since deps/v8 doesn't currently support s390/s390x, pick up
deps/v8z instead.
  • Loading branch information
richardlau authored and gibfahn committed Mar 30, 2016
1 parent 761787b commit fe71722
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 10 deletions.
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,6 @@ ifeq ($(DESTCPU),x86)
V8_ARCH=ia32
else
V8_ARCH ?= $(DESTCPU)

endif

# enforce "x86" over "ia32" as the generally accepted way of referring to 32-bit intel
Expand Down
7 changes: 6 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,15 @@
['GENERATOR == "ninja" or OS== "mac"', {
'OBJ_DIR': '<(PRODUCT_DIR)/obj',
'V8_BASE': '<(PRODUCT_DIR)/libv8_base.a',
}, {
}],
['GENERATOR != "ninja" and OS!= "mac" and target_arch not in "s390 s390x"', {
'OBJ_DIR': '<(PRODUCT_DIR)/obj.target',
'V8_BASE': '<(PRODUCT_DIR)/obj.target/deps/v8/tools/gyp/libv8_base.a',
}],
['GENERATOR != "ninja" and OS!= "mac" and target_arch in "s390 s390x"', {
'OBJ_DIR': '<(PRODUCT_DIR)/obj.target',
'V8_BASE': '<(PRODUCT_DIR)/obj.target/deps/v8z/tools/gyp/libv8_base.a',
}],
['openssl_fips != ""', {
'OPENSSL_PRODUCT': 'libcrypto.a',
}, {
Expand Down
5 changes: 5 additions & 0 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,11 @@ def configure_node(o):
else:
o['variables']['node_enable_v8_vtunejit'] = 'false'

if target_arch in ('s390', 's390x'):
o['variables']['v8_parent_path'] = 'deps/v8z'
else:
o['variables']['v8_parent_path'] = 'deps/v8'

if flavor in ('solaris', 'mac', 'linux', 'freebsd'):
use_dtrace = not options.without_dtrace
# Don't enable by default on linux and freebsd
Expand Down
16 changes: 8 additions & 8 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,16 @@
'dependencies': [
'node_js2c#host',
'deps/cares/cares.gyp:cares',
'deps/v8/tools/gyp/v8.gyp:v8',
'deps/v8/tools/gyp/v8.gyp:v8_libplatform'
'<(v8_parent_path)/tools/gyp/v8.gyp:v8',
'<(v8_parent_path)/tools/gyp/v8.gyp:v8_libplatform'
],

'include_dirs': [
'src',
'tools/msvs/genfiles',
'deps/uv/src/ares',
'<(SHARED_INTERMEDIATE_DIR)', # for node_natives.h
'deps/v8' # include/v8_platform.h
'<(v8_parent_path)' # include/v8_platform.h
],

'sources': [
Expand Down Expand Up @@ -195,8 +195,8 @@
'src/util.cc',
'src/string_search.cc',
'deps/http_parser/http_parser.h',
'deps/v8/include/v8.h',
'deps/v8/include/v8-debug.h',
'<(v8_parent_path)/include/v8.h',
'<(v8_parent_path)/include/v8-debug.h',
'<(SHARED_INTERMEDIATE_DIR)/node_natives.h',
# javascript files to make for an even more pleasant IDE experience
'<@(library_files)',
Expand Down Expand Up @@ -686,12 +686,12 @@
'type': 'executable',
'dependencies': [
'deps/gtest/gtest.gyp:gtest',
'deps/v8/tools/gyp/v8.gyp:v8',
'deps/v8/tools/gyp/v8.gyp:v8_libplatform'
'<(v8_parent_path)/tools/gyp/v8.gyp:v8',
'<(v8_parent_path)/tools/gyp/v8.gyp:v8_libplatform'
],
'include_dirs': [
'src',
'deps/v8/include'
'<(v8_parent_path)/include'
],
'defines': [
# gtest's ASSERT macros conflict with our own.
Expand Down

0 comments on commit fe71722

Please sign in to comment.