-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add simplified door model #1353
Comments
The model has been tested with the Buildings library, commit 10049c0fcc169f4f9141bb191c9fb5b4ba4331cb The computing time is for three models in
The first two models differ by their control, with Guideline 36 having a more detailed control sequence. The last model uses the same building model but no HVAC system. |
Sounds like a substantial difference considering that the rest of the model takes a lot of time to compute. You compared statistics by any chance? |
I didn't drill in further but the number of equations seems similar: There are two states removed because I did not add the error control on the mass that is exchanged. I expect these states not to be needed once #1412 is fixed (which I am working on). |
Above:
This does not seem to be the case from the code so I guess that post is simply outdated? |
The pressure is assumed to be identical for computing the buoyancy-driven part, which is implemented in This is then superposed to the static-pressure-difference driven part. This superposition is the main modeling simplification. |
The current door models
Airflow.DoorDiscretized*
are based on an orifice equation model in which the pressure difference drives the flow rate. If used with an HVAC system that models flow friction in the return duct, then each pressure (or mass) in the room is a state that varies very quickly due to very small difference in pressure of the rooms that are connected. This causes very fast transient of the pressure (or mass), driven by small differential pressures, and the equations are coupled to slow dynamics of temperature, and hence stiff. This causes problems for example inlbl-srg/modelica-buildings#1911 (comment).
It may also be the reason for lbl-srg/modelica-buildings#1895.
This issue is to implement a simplified door model that still allows for bi-directional, temperature difference-driven flow between zone, but it will set the pressure of each zone to be equal. Then, a translator will do index reduction and only use one state for all room pressures (or mass).
The text was updated successfully, but these errors were encountered: