-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring of Media #21
Comments
Based on the phone call of Nov. 21, 2013, we attempt the following structure
Ruben reported that density as a linear function for air is sufficiently accurate from -10 to 80 degC. DryAir will be removed as there is no compelling use case. |
This is for #21. This medium has been added to allow numerical experiments on the large air-based systems in the Buildings library in order to see what that ddifference is between this medium and the new (yet to be implemented) air model.
This is for #21. Made new structure for media. Note that Media.Water still has a constant density, this will need to be changed. Also, Media.Air is using the ideal gas law, this should be changed to an incompressible medium.
This is for #21. The image was moved to the Fluid/UsersGuide directory (to reflect the class in which it is used). The description has been moved to the section 'Implementation' as most users, except for developers, may not need this information.
This is for #21. This change also implements the specificEntropy and the setState_psX functions.
This is for #21. This function needs to return p and not p_reference.
This is for #21. It is needed for Annex60.Fluid.MixingVolumes.Examples.MixingVolumeInitialization to translate.
This is for #21, to allow the volume to also be used with Annex60.Media.Water.
…at it can be executued. This is for #21.
The Water and Air media have been implemented, reviewed and merged to the master. |
Closed because we have separate ticket for brine. |
The current implementation of
Annex60.Media
divides the media in how they are modeled (e.g., IdealGases) and then in the type of the media. This leads to the following abbreviated structure:I suggest to reimplement this as
The rational is that users are looking for a medium, such as moist air, and then decide on what physics it need to capture. This renaming would also avoid the clumsy name
MoistAirUnsaturated
, which should be the default medium for reasons of numerical efficiency.To avoid a repetitive formulation of what physics is implemented in the medium, a user guide would describe the physic of the respective media.
If a library of HVAC components would have specialized models for air, water, and brine, they could mirror the structure of the medium and assign a default media. For example, there could be
Such a hierarchy may be autogenerated, except for the info section.
The text was updated successfully, but these errors were encountered: