Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring of Media #21

Closed
mwetter opened this issue Nov 19, 2013 · 3 comments
Closed

Restructuring of Media #21

mwetter opened this issue Nov 19, 2013 · 3 comments
Assignees
Labels

Comments

@mwetter
Copy link
Contributor

mwetter commented Nov 19, 2013

The current implementation of Annex60.Media divides the media in how they are modeled (e.g., IdealGases) and then in the type of the media. This leads to the following abbreviated structure:

|-- ConstantPropertyLiquidWater
|-- ConstantPropertyLiquidBrine (not yet implemented)
|-- GasesConstantDensity
|   |-- DryAir
|   |-- MoistAir
|   |-- MoistAirUnsaturated
|-- GasesPTDecoupled
|   |-- DryAir
|   |-- MoistAir
|   |-- MoistAirUnsaturated
|-- IdealGases
|   |-- DryAir
|   |-- MoistAir
|   |-- MoistAirUnsaturated

I suggest to reimplement this as

UserGuide
|-- Water
|   |-- ConstantProperty
|-- Brine (to be implemented, with different amounts of solution)
|   |-- ConstantProperty
|-- DryAir
|   |-- ConstantDensity
|   |-- IdealGas
|   |-- PTDecoupled
|-- MoistAir
|   |-- ConstantDensity
|   |-- IdealGas
|   |-- PTDecoupled
|-- MoistAirWithFogRegion
|   |-- ConstantDensity
|   |-- IdealGas
|   |-- PTDecoupled

The rational is that users are looking for a medium, such as moist air, and then decide on what physics it need to capture. This renaming would also avoid the clumsy name MoistAirUnsaturated, which should be the default medium for reasons of numerical efficiency.

To avoid a repetitive formulation of what physics is implemented in the medium, a user guide would describe the physic of the respective media.

If a library of HVAC components would have specialized models for air, water, and brine, they could mirror the structure of the medium and assign a default media. For example, there could be

|-- Fluid (with unspecified medium)
    |-- Sensors
    |-- FlowMachines
|-- MoistAir
    |-- Sensors
    |-- Fans
|-- DryAir
    |-- Sensors
    |-- Fans
|-- Water
    |-- Sensors
    |-- Pumps

Such a hierarchy may be autogenerated, except for the info section.

@ghost ghost assigned mwetter Nov 19, 2013
@mwetter
Copy link
Contributor Author

mwetter commented Nov 21, 2013

Based on the phone call of Nov. 21, 2013, we attempt the following structure

UserGuide
|-- Water
|   |-- ConstantProperty
|-- Brine (to be implemented. Per to send models)
|   |-- ConstantProperty [may be variable density, based on what IDA is using]
|-- MoistAir
|   |-- Incompressible [with density as a function of T. 
                                  Per to send model. 
                                  This used to be ConstantDensity.]
|   |-- PTDecoupled   [keep unless we can show that 
                                 Incompressible computes as well]

Ruben reported that density as a linear function for air is sufficiently accurate from -10 to 80 degC.

DryAir will be removed as there is no compelling use case.

mwetter added a commit that referenced this issue Nov 21, 2013
This is for #21. This medium has been added to allow numerical experiments on the large air-based systems in the Buildings library in order to see what that ddifference is between this medium and the new (yet to be implemented) air model.
mwetter added a commit that referenced this issue Nov 21, 2013
This is for #21.
mwetter added a commit that referenced this issue Nov 21, 2013
This is for #21.
mwetter added a commit that referenced this issue Nov 22, 2013
This is for #21.
Made new structure for media.
Note that Media.Water still has a constant density, this will need to
be changed.
Also, Media.Air is using the ideal gas law, this should be changed to
an incompressible medium.
rubenbaetens added a commit that referenced this issue Nov 22, 2013
- General changes on the (final) propagation or redeclaration of parameters.
- Icon changes.
- MSL-version change.
- Full redefinition of MoistAirUnsaturated > Approved, further development will be addressed in #21 due to restructureing of Media.
- Conflict solved in f63b31b.
mwetter added a commit that referenced this issue Nov 22, 2013
This is for #21. The image was moved to the Fluid/UsersGuide directory (to reflect the class in which it is used). The description has been moved to the section 'Implementation' as most users, except for developers, may not need this information.
mwetter added a commit that referenced this issue Nov 22, 2013
mwetter added a commit that referenced this issue Nov 27, 2013
This is for #21. This change also implements the specificEntropy and the setState_psX functions.
mwetter added a commit that referenced this issue Dec 2, 2013
mwetter added a commit that referenced this issue Dec 4, 2013
mwetter added a commit that referenced this issue Dec 4, 2013
This is for #21.
mwetter added a commit that referenced this issue Dec 5, 2013
This is for #21. This function needs to return p and not p_reference.
mwetter added a commit that referenced this issue Dec 10, 2013
This is for #21. It is needed for
 Annex60.Fluid.MixingVolumes.Examples.MixingVolumeInitialization
to translate.
mwetter added a commit that referenced this issue Dec 13, 2013
mwetter added a commit that referenced this issue Dec 18, 2013
mwetter added a commit that referenced this issue Dec 18, 2013
This is for #21, to allow the volume to also be used with Annex60.Media.Water.
mwetter added a commit that referenced this issue Dec 18, 2013
mwetter added a commit that referenced this issue Dec 18, 2013
mwetter added a commit that referenced this issue Dec 18, 2013
This is for #21.
mwetter added a commit that referenced this issue Dec 18, 2013
This is for #21.
mwetter added a commit that referenced this issue Dec 18, 2013
mwetter added a commit that referenced this issue Dec 18, 2013
mwetter added a commit that referenced this issue Dec 18, 2013
mwetter added a commit that referenced this issue Dec 19, 2013
mwetter added a commit that referenced this issue Dec 19, 2013
mwetter added a commit that referenced this issue Dec 20, 2013
mwetter added a commit that referenced this issue Dec 20, 2013
mwetter added a commit that referenced this issue Dec 20, 2013
mwetter added a commit that referenced this issue Dec 20, 2013
mwetter added a commit that referenced this issue Dec 20, 2013
mwetter added a commit that referenced this issue Dec 20, 2013
This is for #21.
mwetter added a commit that referenced this issue Jan 9, 2014
@mwetter mwetter mentioned this issue Feb 19, 2014
mwetter added a commit that referenced this issue Mar 1, 2014
mwetter added a commit that referenced this issue Mar 1, 2014
@mwetter
Copy link
Contributor Author

mwetter commented Mar 1, 2014

The Water and Air media have been implemented, reviewed and merged to the master.
What remains to be done is implementation of Brine solutions with user-selectable concentration.

@mwetter
Copy link
Contributor Author

mwetter commented Mar 9, 2014

Closed because we have separate ticket for brine.

@mwetter mwetter closed this as completed Mar 9, 2014
mwetter pushed a commit that referenced this issue Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant