-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pressure state for incompressible media #225
Comments
@Mathadon : I looked into that as on branch
fails with
Can you point to a test case where you see these additional derivatives? Simply setting
in |
If you enable
The inlet pressure is identical to the pressure state value. A discontinuous change in inlet pressure would therefore lead to an infinite mass flow rate. For solving the problem correctly Dymola therefore requires the derivative of the inlet pressure to be known, since
but this derivative is not used in the model so it seems to be no problem. This of course means that massDynamics need to be steady state. If you do want to use compressible air I think you'll need to make FMU's of a series connection of a pressure drop component and a mixing volume. And not of an individual mixing volume. Note that this problem is not entirely related to the issue. An example of this issue is example
while we're not at all interested in the derivative of the pressure, only in the pressure. |
This is for #225 and also required to export volumes as FMUs for lbl-srg/modelica-buildings#313
It turns out that 116194d gives smaller systems of equations in some models of the Buildings library. For example,
and computing time changed from about 10 to 9 seconds. |
- https://github.com/lbl-srg/modelica-buildings.git branch master updated to 5a78c76d5b26d8910427db17f00ab3da49fb4712. * [lbl-srg/modelica-buildings@5a78c76 5a78c76] Removed stateSelect on pressure for ibpsa/modelica-ibpsa#225 * [lbl-srg/modelica-buildings@d2149f9 d2149f9] Updated reference results for #417. * [lbl-srg/modelica-buildings@c62e6cb c62e6cb] Reformulated to reduce use of divmacro. For #417 - https://github.com/modelica-3rdparty/ExternData.git branch master has FAILING head - latest is e292e462e3bca6f1f1e18e70bb3af3f75ac85a58 * [modelica-3rdparty/ExternData@e292e46 e292e46] Rebuild always * [modelica-3rdparty/ExternData@ab9c399 ab9c399] Rebuild always * [modelica-3rdparty/ExternData@503ed70 503ed70] Update version * [modelica-3rdparty/ExternData@8481e74 8481e74] Add library version and info - https://github.com/modelica/Modelica.git branch master updated to e3494fcc35577ae95eb96c50e3276fbf73463c28. * [modelica/ModelicaStandardLibrary@e3494fc e3494fc] refs #1720: Fix explicit NULL test
> Bump libraries - https://github.com/lbl-srg/modelica-buildings.git branch master updated to 5a78c76d5b26d8910427db17f00ab3da49fb4712. * [lbl-srg/modelica-buildings@5a78c76 5a78c76] Removed stateSelect on pressure for ibpsa/modelica-ibpsa#225 * [lbl-srg/modelica-buildings@d2149f9 d2149f9] Updated reference results for #417. * [lbl-srg/modelica-buildings@c62e6cb c62e6cb] Reformulated to reduce use of divmacro. For #417
Removed stateSelect on pressure for #225
This was fixed by #248 |
When using incompressible media derivatives of pressures are generated when
massDynamics not = steadyState
because of thestateSelect.prefer
declaration. This causes additional derivatives to be computed since there is no real state for the pressure when the medium is incompressible.I will do some tests to check if it's best to remove the stateSelect.prefer or to set it to the mixing volume mass. We should also run unit tests and performance benchmarks to assess the impact.
The text was updated successfully, but these errors were encountered: