-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move plugflowpipe to baseclasses #1537
Conversation
@mwetter If all test passes, this is ready to merge. This brings in the MBL changes to IBPSA. |
@baptiste Ravache ***@***.***> : do you also want to add the
discretized plug flow pipe or is there a reason to omit it?
…On Fri, Oct 15, 2021, 11:27 AM Baptiste Ravache ***@***.***> wrote:
@mwetter <https://github.com/mwetter> If all test passes, this is ready
to merge. This brings in the MBL changes to IBPSA.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1537 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKEPOGR3YV332ZHGHCC2HTUHBXCFANCNFSM5GCQXI6Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@mwetter : No reason, except that I assumed that the level of scrutiny for merging the Do you recommend I add it now? Would I need to restart the panel review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to merge from my point of view.
@Mathadon : Can you please review so we have a non-LBL reviewer. |
I'm just wondering whether |
@Mathadon : Thanks, I updated the revision history and will merge it after the tests pass. |
Implement PlugFlowPipeDiscretized
This closes #1538 |
The main change of this PR is to move the content of
IBPSA/Fluid/FixedResistances/PlugFlowPipe.mo
toIBPSA/Fluid/FixedResistances/BaseClasses/PlugFlowPipe.mo
and have the internal pipe resistance elementres
replaceable.The exposed class has the same behavior as previously, and the baseclass can be reused to replace the pipe resistance with a
LosslessPipe
.