You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unit tests for the data/data_manager.py and data/data_generator.py in #370 and #367 are failing because of the inclusion of a new column variable being generated by the BoundaryCondition model in the Modelica IBPSA Library that is not expected in the reference results, alt. This was introduced recently to the Modelica IBPSA master in ibpsa/modelica-ibpsa#1520 referencing ibpsa/modelica-ibpsa#1477.
This issue can be fixed by freezing the Modelica IBPSA commit used in the jm docker container used to generate the resource data in the unit tests. This would align with the resource weather data currently included in the test case FMUs.
If we were to update such that the alt variable is an acceptable column variable, we should also update in the test case FMUs, which would require recompilation using updated versions of dependent Modelica Libraries (such as Buildings and IDEAS) to be consistent. Note that they'd have to use specific master commits, since the latest released versions with numbers do not yet include the updated Modelica IBPSA library generating alt.
The text was updated successfully, but these errors were encountered:
Unit tests for the
data/data_manager.py
anddata/data_generator.py
in #370 and #367 are failing because of the inclusion of a new column variable being generated by the BoundaryCondition model in the Modelica IBPSA Library that is not expected in the reference results,alt
. This was introduced recently to the Modelica IBPSA master in ibpsa/modelica-ibpsa#1520 referencing ibpsa/modelica-ibpsa#1477.This issue can be fixed by freezing the Modelica IBPSA commit used in the
jm
docker container used to generate the resource data in the unit tests. This would align with the resource weather data currently included in the test case FMUs.If we were to update such that the
alt
variable is an acceptable column variable, we should also update in the test case FMUs, which would require recompilation using updated versions of dependent Modelica Libraries (such as Buildings and IDEAS) to be consistent. Note that they'd have to use specific master commits, since the latest released versions with numbers do not yet include the updated Modelica IBPSA library generatingalt
.The text was updated successfully, but these errors were encountered: