Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests failing due to new "alt" weather variable #371

Closed
dhblum opened this issue Oct 18, 2021 · 1 comment
Closed

Unit tests failing due to new "alt" weather variable #371

dhblum opened this issue Oct 18, 2021 · 1 comment

Comments

@dhblum
Copy link
Collaborator

dhblum commented Oct 18, 2021

Unit tests for the data/data_manager.py and data/data_generator.py in #370 and #367 are failing because of the inclusion of a new column variable being generated by the BoundaryCondition model in the Modelica IBPSA Library that is not expected in the reference results, alt. This was introduced recently to the Modelica IBPSA master in ibpsa/modelica-ibpsa#1520 referencing ibpsa/modelica-ibpsa#1477.

This issue can be fixed by freezing the Modelica IBPSA commit used in the jm docker container used to generate the resource data in the unit tests. This would align with the resource weather data currently included in the test case FMUs.

If we were to update such that the alt variable is an acceptable column variable, we should also update in the test case FMUs, which would require recompilation using updated versions of dependent Modelica Libraries (such as Buildings and IDEAS) to be consistent. Note that they'd have to use specific master commits, since the latest released versions with numbers do not yet include the updated Modelica IBPSA library generating alt.

@dhblum
Copy link
Collaborator Author

dhblum commented Oct 19, 2021

Closed by #373.

dhblum added a commit that referenced this issue Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant