Issue409 two zone apartment hydronic #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new testcase called two_zone_apartment_hydronic
merge master into local issue
…icApartment Add first emulator review.
Update local brach to last master version
…nicApartment Add second emulator review.
…m/EttoreZ/project1-boptest into issue409_TwoZoneHydronicApartment
merge local master into issue branch
update local master
update local master with origin master
update branch with latest version of the master
Co-authored-by: Javier <[email protected]>
Merging to staging branch.
dhblum
commented
Sep 20, 2022
There was a problem hiding this comment.
@EttoreZ Thanks again for the emulator. I reviewed and just have some comments before merging to master, please see my inline comments. I'm sorry, but they will require regeneration of unit test results and updating of docs. Can you make a PR(s) against this branch with changes?
...two_zone_apartment_hydronic/models/TwoZoneApartmentHydronic/TestCases/ApartmentModelQHTyp.mo
Outdated
Show resolved
Hide resolved
testcases/two_zone_apartment_hydronic/models/library_versions.json
Outdated
Show resolved
Hide resolved
...cases/two_zone_apartment_hydronic/models/TwoZoneApartmentHydronic/Components/Thermostat_T.mo
Outdated
Show resolved
Hide resolved
.../two_zone_apartment_hydronic/models/TwoZoneApartmentHydronic/Components/Rooms/thermalZone.mo
Outdated
Show resolved
Hide resolved
.../two_zone_apartment_hydronic/models/TwoZoneApartmentHydronic/Components/Rooms/thermalZone.mo
Outdated
Show resolved
Hide resolved
Issue409 two zone apartment hydronic
Merging to staging branch
|
Ready to merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #409.