Add original license test to bench.rs, and omit it and other unnecessary files from published crates #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since bench.rs is derived from the bench.rs in sharded-slab, and the MIT license says “The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software,” we need to include the original license text. Using a source comment to include the license text should be adequate, since it’s unlikely anyone would want to distribute the compiled benchmark executable.
This makes the crate archives slightly smaller, and makes it very clear that nothing derived from sharded-slab is compiled into the crate library, which makes downstream license analysis easier.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
bench.rsis derived from thebench.rsinsharded-slab, and the MIT license says “The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software,” we need to include the original license text.Using a source comment to include the license text should be adequate, since it’s unlikely anyone would want to distribute the compiled benchmark executable.
As a follow-up, this PR excludes the benchmarks (along with a few other unnecessary files) from published crates. This makes the crate archives slightly smaller, and makes it very clear that nothing derived from
sharded-slabis compiled into the crate library, which makes downstream license analysis easier.