Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix color issue with Debugger::explain implementation for Renderer #1109

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix color issue with Debugger::explain implementation for Renderer #1109

merged 1 commit into from
Nov 4, 2021

Conversation

mettz
Copy link
Contributor

@mettz mettz commented Nov 3, 2021

This PR should fix an issue with the actual implementation of layout::Debugger where the argument color of the explain method is ignored

hecrj
hecrj approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a silly bug!

Thank you! 🙇

@hecrj hecrj added the bug Something isn't working label Nov 4, 2021
@hecrj hecrj added this to the 0.4.0 milestone Nov 4, 2021
@hecrj hecrj merged commit 61c747b into iced-rs:master Nov 4, 2021
@hecrj hecrj mentioned this pull request Jan 19, 2022
Closed
@hecrj hecrj mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mettz @hecrj