Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Widget::height for Component #1149

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix Widget::height for Component #1149

merged 1 commit into from
Dec 9, 2021

Conversation

nicksenger
Copy link
Contributor

This updates Widget:height for Component to use height rather than width of the cached element.

hecrj
hecrj approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, too much copy-paste! 😅

Thank you!

@hecrj hecrj added the bug Something isn't working label Dec 9, 2021
@hecrj hecrj added this to the 0.4.0 milestone Dec 9, 2021
@hecrj hecrj merged commit aa96a0a into iced-rs:master Dec 9, 2021
@nicksenger nicksenger deleted the fix/component-height branch February 17, 2022 08:43
@hecrj hecrj mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nicksenger @hecrj