Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TextInput emit a Submit message when the key NumpadEnter is pressed #1150

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Make TextInput emit a Submit message when the key NumpadEnter is pressed #1150

merged 1 commit into from
Dec 9, 2021

Conversation

thenlevy
Copy link
Contributor

@thenlevy thenlevy commented Dec 9, 2021

Currently TextInputs only emit their on_submit message when the "main" Enter key is pressed. I believe they should also do so when the Enter key from the numpad is pressed.

@hecrj hecrj added the improvement An internal improvement label Dec 9, 2021
@hecrj hecrj added this to the 0.4.0 milestone Dec 9, 2021
hecrj
hecrj approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! Thanks 🥂

@hecrj hecrj merged commit a98a8c1 into iced-rs:master Dec 9, 2021
@hecrj hecrj mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thenlevy @hecrj