Decouple image::Handle from iced_native and lower trait bound on text::Renderer::Font
#1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisCode
force-pushed
the
refactor/decouple_image
branch
from
a3e08ad
to
d06e6bf
Compare
hecrj
changed the title
image::Handle from iced_native and lower trait bound on text::Renderer::Font
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on discord, the goal of this PR is to make
iced_native's widgets usable in more contexts (including potentially a Backend for a well-known Rust game engine, who knows 👀 ) by :Handleinstead of relying oniced_native'simage::Handlewhich is impractical for custom backendsCopytoCloneThis is a breaking change for
iced_nativebecause any custom renderer will need to add the associated typeHandleto thetext::Rendererimplementation.