Fix component overlay position #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cossonleo
force-pushed
the
master
branch
2 times, most recently
from
8fe99ed
to
c5dbfb2
Compare
hecrj
requested changes
Jan 20, 2022
Comment on lines
+274
to
+275
| has_overlay.map(|pos| { | ||
| overlay::Element::new(pos, Box::new(Overlay { instance: self })) |
There was a problem hiding this comment.
Let's avoid unnecessary abbreviations!
Suggested change
| has_overlay.map(|pos| { | |
| overlay::Element::new(pos, Box::new(Overlay { instance: self })) | |
| has_overlay.map(|position| { | |
| overlay::Element::new(position, Box::new(Overlay { instance: self })) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position change from component position to widget with overlay position.