Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cow<'static, [u8]> in image/svg, add constructors taking &[u8]` #1453

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Use Cow<'static, [u8]> in image/svg, add constructors taking &[u8]` #1453

merged 2 commits into from
Nov 5, 2022

Commits on Oct 3, 2022

  1. Use Cow<'static, [u8]> in image/svg, add constructors taking &[u8]` 

    This should resolve iced-rs#580 by
providing a way to use an image included with `include_bytes!` without
needing to copy it to a `Vec` to create an image handle.

It would be nice if these methods could also be `const`, but that isn't
possible due to the hashing being done.

This is technically a breaking change since `Handle::data()` is public.
But if that is used, it's most likely in used somewhere that only relies
on the type derefing to `&[u8]`.
    @ids1024
    ids1024 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6ce12fc View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. Unify methods by leveraging Into<Cow> in image and svg

    @hecrj
    hecrj committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    bc5986c View commit details
    Browse the repository at this point in the history