Configurable width for Scrollable
#1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we should strive for widgets to have very specialized purposes and have fewer responsibilities in the long run. If this behavior can already be achieved with a |
|
I forgot that scrollables now can scroll horizontally as well! A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1704.
Add width to scrollables so you can do stuff like
.width(Length::Fill)to make the scroll bar appear on the edge of the screen, previously as far as I'm aware you had to set the width of the scrollables child element instead.I've tested by running the scrollable example project and my own project which uses a scrollable and it appears to work correctly with no unexpected side effects but I'm not sure if there is a more rigorous way to test these changes.