Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComboBox widget #1954

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Add ComboBox widget #1954

merged 7 commits into from
Jul 26, 2023

Conversation

jhff
Copy link
Contributor

@jhff jhff commented Jul 13, 2023

Summary

This widget combines a TextInput with a Menu to produce a dropdown list of searchable and selectable options.

Rotating through the options with the arrow keys can also produce messages by adding a Message to on_selection without actually changing the widget value. This can be helpful for, e.g., previewing options.

Demo

combobox

@Mingun
Copy link

Mingun commented Jul 13, 2023

For aesthetic, left & right padding of the menu should be the same as padding of the text box. The arrow control that will serve as a visual indicator of a dropdown menu, are also very welcome

@hecrj hecrj added the feature New feature or request label Jul 15, 2023
@hecrj hecrj added this to the 0.10.0 milestone Jul 15, 2023
@hecrj hecrj added the widget label Jul 15, 2023
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks 🥳

Fixed and renamed some minor things, but everything looks good 🚢

@hecrj hecrj enabled auto-merge July 26, 2023 20:38
@hecrj hecrj merged commit a0a3cf7 into iced-rs:master Jul 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants