Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underline support for rich_text #2526

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Underline support for rich_text #2526

merged 3 commits into from
Jul 28, 2024

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Jul 28, 2024

This PR introduces a new underline method to text::Span that can be used to underline text:

image

It is far from perfect, but it may be good enough in some circumstances!

@hecrj hecrj added this to the 0.13 milestone Jul 28, 2024
@tarkah
Copy link
Member

tarkah commented Jul 28, 2024

Let's add strikethrough as well with this 😎

@hecrj
Copy link
Member Author

hecrj commented Jul 28, 2024

@tarkah New PR coming.

@hecrj hecrj merged commit ebc6c0e into master Jul 28, 2024
24 checks passed
@hecrj hecrj deleted the feature/rich-text-underline branch July 28, 2024 15:22
@hecrj hecrj mentioned this pull request Jul 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
addition feature New feature or request rendering styling text widget
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
2 participants
@hecrj @tarkah