feat: set total size of QRCode #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolk131
commented
Sep 25, 2024
widget/src/qr_code.rs
Outdated
| @@ -84,11 +84,17 @@ where | |||
| } | |||
|
|
|||
| /// Sets the size of the squares of the grid cell of the [`QRCode`]. | |||
| pub fn cell_size(mut self, cell_size: u16) -> Self { | |||
| pub fn cell_size(mut self, cell_size: f32) -> Self { | |||
There was a problem hiding this comment.
Note for reviewer: This is a breaking change to the public API. Let me know if that's a problem! We can easily keep the rest of the changes and revert this back to accepting a u16.
hecrj
force-pushed
the
qr_code_fixed_size
branch
from
374e30f
to
b02ec8b
Compare
hecrj
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.