Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image format options to reduce code bloat #392

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

valpackett
Copy link
Contributor

@valpackett valpackett commented Jun 5, 2020

Fixes #376.

@hecrj hecrj changed the title Add image format options to reduce code bloat, fixes #376 Add image format options to reduce code bloat Jun 8, 2020
@hecrj hecrj added the improvement An internal improvement label Jun 18, 2020
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🥳 I have rebased onto master without issues.

And sorry for the delay! I wanted to find a way to expose the individual features in the root iced crate too, but it'd be quite cumbersome to do so currently.

In any case, I think this is still very valuable for those that want to integrate iced_wgpu in their own event loop. Also, relying on iced_winit directly is always an option.

I think we can go ahead and merge!

@hecrj hecrj added this to the 0.3.0 milestone Feb 13, 2021
@hecrj hecrj merged commit 4de164d into iced-rs:master Feb 13, 2021
@valpackett valpackett deleted the image-debloat branch March 31, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An internal improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image format options to reduce code bloat
2 participants