add scrolling to pick_lists #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hecrj
requested changes
May 25, 2021
hecrj
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Looks great! Thanks! 🎉
I have abstracted and simplified the logic a bit in 6069e90 so there's not as much code duplication and we avoid edge cases when the list of options is empty.
Additionally, I have disabled the scrolling behavior for the Pixels variant of ScrollDelta. This way, the PickList will react to discrete scroll events (e.g. an actual mouse wheel) while dismissing continuous scroll events (e.g. scrolling with a trackpad).
I believe this ship is ready to sail! 🚢
|
No, thank you!!!!!! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to clean up #729 as that PR had 3 features, 2 of which are handled by iced_aw/#11 and #607.
All this PR does is create a message with a new Pick_List value when a scroll event is detected on said Pick_List.