Update format.yml and clippy.yml #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2023 08:33
add nightly to the test for fmt.
update to add nightly checks.
Luni-4
reviewed
Jun 8, 2023
| @@ -2,11 +2,16 @@ name: Format | |||
| on: [push, pull_request] | |||
| jobs: | |||
| all: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ${{ matrix.os }} | |||
There was a problem hiding this comment.
We can use ubuntu-latest directly here since it's the only supported os
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] |
There was a problem hiding this comment.
Remove this line if the comment above is going to be accepted
| @@ -2,11 +2,16 @@ name: Clippy | |||
| on: [push, pull_request] | |||
| jobs: | |||
| all: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ${{ matrix.os }} | |||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest] |
There was a problem hiding this comment.
yeah i remove the os part in a new PR since i had already merged this. Originally left it just in case we needed to add in windows and mac. but to keep it simple for now linux should cover most stuff and the matrix os can be added back later when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add nightly to the test for fmt.