Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added segmented button,segmented button style, and example #193

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

bq-wrongway
Copy link
Contributor

This is just a preliminary pull request, i am looking forward to your feedback in order to change, addend and improve this pull merge request.

Thank you!

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the image and svgs then this can be merged.

examples/segmented_button/resources/dl.svg Outdated Show resolved Hide resolved
examples/segmented_button/resources/file_add.png Outdated Show resolved Hide resolved
examples/segmented_button/resources/ico.svg Outdated Show resolved Hide resolved
examples/segmented_button/resources/light.svg Outdated Show resolved Hide resolved
@bq-wrongway
Copy link
Contributor Author

You are right, i forgot about those.
I have deleted the whole folder since i was just using that to test and preview.

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good once the checks have passed I can merge this in.

@genusistimelord
Copy link
Collaborator

looks like there are some formatting and clippy issues you need to fix.

@bq-wrongway
Copy link
Contributor Author

Hey, i have fixed both linting and formating issues, and on my machine they are passing all the checks at the moment!
Thank you for your patience

@genusistimelord genusistimelord merged commit 99e5bc1 into iced-rs:main Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants