Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolating invisible models bug #33

Closed
wants to merge 55 commits into from
Closed

Isolating invisible models bug #33

wants to merge 55 commits into from

Conversation

iceiix
Copy link
Owner

@iceiix iceiix commented Nov 26, 2018

Attempt to reduce a test case for https://github.com/iceiix/steven/issues/25 Invisible players/models

@iceiix
Copy link
Owner Author

iceiix commented Nov 26, 2018

Observed heightP and texP uninitialized warnings: https://github.com/iceiix/steven/issues/32, but removed clouds_geo in f219e98 so it wasn't causing this problem.

Would like to use code coverage to help create a more minimal reproduction case, found https://users.rust-lang.org/t/tutorial-how-to-collect-test-coverages-for-rust-project/650 and compiled kcov as in https://github.com/SimonKagstrom/kcov/blob/master/INSTALL.md, used master commit ab4774d6798a17b908b10119e7c06a017566c4ba Thu Oct 25 10:03:55 2018 on Ubuntu 18.04.1, but it crashes with:

ubuntu@ubuntu-virtual-machine:~/steven$ kcov --verify target/cov target/release/steven
kcov: 1 invalid breakpoints skipped in /lib/x86_64-linux-gnu/libdl.so.2
kcov: 3 invalid breakpoints skipped in /lib/x86_64-linux-gnu/librt.so.1
kcov: 7 invalid breakpoints skipped in /lib/x86_64-linux-gnu/libpthread.so.0
kcov: 2 invalid breakpoints skipped in /lib/x86_64-linux-gnu/libc.so.6
kcov: 1 invalid breakpoints skipped in /lib/x86_64-linux-gnu/libnsl.so.1
kcov: 262 invalid breakpoints skipped in /lib/x86_64-linux-gnu/libresolv.so.2
Starting steven
kcov: Process exited with signal 4 (SIGILL) at 0x7ffff62bc6f3

kcov: Illegal instructions are sometimes caused by some GCC versions
kcov: miscompiling C++ headers. If the problem is persistent, try running
kcov: with --verify. For more information, see
kcov: http://github.com/SimonKagstrom/kcov/issues/18

crash in gdb:

Thread 2 "kcov" received signal SIGTERM, Terminated.
[Switching to Thread 0x7ffff0466700 (LWP 16408)]
0x00007ffff783edae in __libc_open64 (
    file=0x555555d0e9c0 "target/cov//steven.cca448123baac1fd/kcov-solib.pipe", oflag=oflag@entry=0)
    at ../sysdeps/unix/sysv/linux/open64.c:47
47	../sysdeps/unix/sysv/linux/open64.c: No such file or directory.
(gdb) bt
#0  0x00007ffff783edae in __libc_open64 (
    file=0x555555d0e9c0 "target/cov//steven.cca448123baac1fd/kcov-solib.pipe", oflag=oflag@entry=0)
    at ../sysdeps/unix/sysv/linux/open64.c:47
#1  0x00005555555c5712 in open (__oflag=0, __path=<optimized out>)
    at /usr/include/x86_64-linux-gnu/bits/fcntl2.h:53
#2  SolibHandler::solibThreadParse (this=0x555555ceea70) at /home/ubuntu/kcov/src/solib-handler.cc:144
#3  0x00005555555c58d8 in SolibHandler::solibThreadMain (this=0x555555ceea70)
    at /home/ubuntu/kcov/src/solib-handler.cc:187
#4  SolibHandler::threadStatic (pThis=0x555555ceea70) at /home/ubuntu/kcov/src/solib-handler.cc:196
#5  0x00007ffff78346db in start_thread (arg=0x7ffff0466700) at pthread_create.c:463
#6  0x00007ffff634a88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) 

so we don't have code coverage to help...

But the current status is more minimal than began with, sun/moon shown on Ubuntu 18.04.1 in VMware Fusion, correctly:

screen shot 2018-11-25 at 6 18 29 pm

and there is the sky, but no sun model on AMD Radeon Pro 580, iMac 2017, macOS 10.14 (and AMD Radeon R9 M295X on iMac late 2014, Intel HD Graphics 4000 on MacBook Air mid-2012 macOS 10.13.6), the bug:

screen shot 2018-11-25 at 6 19 24 pm

@iceiix
Copy link
Owner Author

iceiix commented Nov 26, 2018

  • main src/main.rs
    • src/render/shader.rs
      • src/render/shaders/trans_frag.glsl, src/render/shaders/trans_vertex.glsl
      • src/render/shaders/model_frag.glsl, src/render/shaders/model_vetex.glsl
      • src/render/shaders/sun_frag.glsl, src/render/shaders/sun_vetex.glsl
    • sun_model.tick src/server/sun.rs
    • game.renderer.tick src/render/mod.rs
      • self.model.draw src/render/model.rs
        • gl::draw_elements
      • trans.trans.bind
      • trans.draw

@iceiix
Copy link
Owner Author

iceiix commented Nov 27, 2018

Moved to a new separate smaller project, without (most) of the extra code: https://github.com/iceiix/invisible

@iceiix iceiix closed this Nov 27, 2018
@iceiix iceiix deleted the invisible branch November 27, 2018 02:47
@iceiix
Copy link
Owner Author

iceiix commented Nov 27, 2018

screen shot 2018-11-27 at 12 42 35 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant