Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.59.0 #718

Merged
merged 4 commits into from
Aug 28, 2022
Merged

Update to Rust 1.59.0 #718

merged 4 commits into from
Aug 28, 2022

Conversation

iceiix
Copy link
Owner

@iceiix iceiix commented Aug 28, 2022

https://blog.rust-lang.org/2022/02/24/Rust-1.59.0.html

attempt to fix build failure #717 (comment)

package time v0.3.14 cannot be built because it requires rustc 1.59.0 or newer, while the currently active rustc version is 1.58.1

@iceiix iceiix marked this pull request as ready for review August 28, 2022 13:48
@iceiix
Copy link
Owner Author

iceiix commented Aug 28, 2022

warning: single-character string constant used as pattern
   --> src/console/mod.rs:373:61
    |
373 |         let mut file = &record.file().unwrap_or("").replace("\\", "/")[..];
    |                                                             ^^^^ help: try using a `char` instead: `'\\'`
    |
    = note: `#[warn(clippy::single_char_pattern)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern

warning: unneeded late initalization
    --> src/server/mod.rs:1950:17
     |
1950 |                 let action;
     |                 ^^^^^^^^^^^
     |
     = note: `#[warn(clippy::needless_late_init)]` on by default
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
help: declare `action` here
     |
1951 |                 let action = match tile_id {
     |                 ++++++++++++
help: remove the assignments from the `match` arms
     |
1953 -                     "Sign" => action = 9,
1953 +                     "Sign" => 9,
     | 
help: add a semicolon after the `match` expression
     |
1956 |                 };
     |                  +

warning: single-character string constant used as pattern
   --> src/ui/logo.rs:102:63
    |
102 |                     text_strings.push(line.to_owned().replace("\r", ""));
    |                                                               ^^^^ help: try using a `char` instead: `'\r'`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern

@iceiix iceiix merged commit bbbe58a into master Aug 28, 2022
@iceiix iceiix deleted the rust1.59 branch August 28, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant