manually remove 'z' from datetime string

[JessicaS11]

Per the segfault issue noted in #281, Xarray/pandas/numpy no longer automatically handle datetimes brought in with a timezone ('Z' at the end of the datetime string). This provides a fix by checking and manually removing the last character of the datetime string if it's a Z.

[github-actions]

👈 Launch a binder notebook on this branch for commit 076d149

I will automatically update this comment whenever this PR is modified

👈 Launch a binder notebook on this branch for commit 35435d1

[ricardobarroslourenco]

Does it need to merge this PR, with the other one ( #281 )?

[weiji14]

Really think we need a unit test for the Read module, do you have time to add one in?

[JessicaS11]

Does it need to merge this PR, with the other one ( #281 )?

Yes - it turns out this was a standalone issue occurring for other datasets too (due to a deprecation in the most recent versions of numpy, v 1.22), so we gave it its own PR. Once we merge this into development, we can update #281 and fingers crossed that PR will be good to go too.

[JessicaS11]

Really think we need a unit test for the Read module, do you have time to add one in?

Agreed. I won't have time until after the hackweek. : )

[codecov-commenter]

Codecov Report

Merging #294 (a02bc41) into development (768c520) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development     #294      +/-   ##
===============================================
- Coverage        55.56%   55.47%   -0.09%     
===============================================
  Files               31       31              
  Lines             2014     2017       +3     
  Branches           412      413       +1     
===============================================
  Hits              1119     1119              
- Misses             825      828       +3     
  Partials            70       70              

Impacted Files	Coverage Δ
icepyx/core/read.py	29.47% <0.00%> (-0.53%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768c520...a02bc41. Read the comment docs.

[weiji14]

Cool, thanks Jessica! I've tested locally on ATL06 and the data loads fine into xarray. Also tried on ATL08 and there's still the IndexError, but at least it doesn't crash. Not sure about the other ICESat-2 products 🙂