Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unzip hdf5 files into one directory instead of many #63

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jun 7, 2020

The downloaded zip file stores each HDF5 file in separate subfolders. This Pull Request fixes #33 by modifying the unzipping code so that the files are all in a single folder (the download folder set by the user). I.e. instead of having this:

  • download_folder
    • 123456789
      • processed_ATL06_2019*.h5
    • 234567891
      • processed_ATL06_2019*.h5
    • 345678912
      • processed_ATL06_2019*.h5
    • 456789123
      • processed_ATL06_2019*.h5

The unzip will now do this:

  • download_folder
    • processed_ATL06_2019*.h5
    • processed_ATL06_2019*.h5
    • processed_ATL06_2019*.h5
    • processed_ATL06_2019*.h5

There seems to be an extract argument (which takes a boolean True/False) that is commented out in the code, should I enable it?

@JessicaS11
Copy link
Member

@weiji14 The extract keyword is commented out because it was not yet fully implemented. It would be great to have that functionality for those who do not want to automatically unzip their downloaded files (especially for very large datasets). I think it would be best to keep/set the default behavior as extract=True though.

@JessicaS11 JessicaS11 merged commit e929acd into master Jun 8, 2020
@weiji14 weiji14 deleted the unzip_into_onedir branch June 8, 2020 22:57
@weiji14
Copy link
Member Author

weiji14 commented Jun 8, 2020

Yes, especially since there are ways to read the data inside the zipfile without explicitly unzipping them. Leave that for a separate Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

downloaded file unzipping and sorting
2 participants