Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for build exception in Node v13.13+ #287

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

cewald
Copy link
Contributor

@cewald cewald commented Apr 15, 2020

After the update to @babel/preset-env ^7.8.6" I faced the exception during the build on a plain machine:

ERROR in ./core/service-worker/index.js Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Cannot find module '@babel/compat-data/corejs3-shipped-proposals'

I've found this issue mentioned in the latest commits of the babel plugin and upgraded to 7.9.0 as recommended: babel/babel#11283 and nodejs/node#32852

@cewald cewald merged commit 00b659b into develop-2020-04-11 Apr 15, 2020
@cewald cewald deleted the bugfix/node-vs-babel-version-conflict branch April 15, 2020 09:55
@cewald cewald mentioned this pull request Apr 16, 2020
cewald added a commit that referenced this pull request Apr 16, 2020
* Merge latest `DivanteLtd/develop` into `develop` (#280, #289) 
* #196865 Add SEO-Text Component (#285) 
* #199077 Add `icmaa-cdn` module (#286) 
* #197501 Improve `SearchPanel` component (#284) 
* #187376 Bugfix for GTM tracking (#283) 
* #197501 Improve `SearchPanel` category results (#282) 
* Bugfix for build exception in Node v13.13+ (#287) 
* Add defaults to `sortedProductOptions` of `optionsMixin` in `icmaa-imp` theme (#290) 
* Add our custom filter to `SearchPanel` component for custom search (#281) 
* Bugfix for empty cms blocks in `icmaa-cms` block component (#292)
* Remove unnecessary custom `api-search-query` search adapter
guhungry added a commit to guhungry/react-native-fast-image that referenced this pull request Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant