Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the BZip2 Compress/Decompress functions to throw ArgumentNullxception rather than Exception when null stream parameters are provided #432

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Mar 30, 2020

Pretty trivial, but just something I noticed while looking at the code - throwing a base Exception for a null parameter doesn't seem ideal - ArgumentNullException with the parameter name specified seems better?

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

…xception rather than Exception when null stream parameters are provided
@piksel piksel merged commit f36ca37 into icsharpcode:master Apr 13, 2020
@Numpsy Numpsy deleted the rw/bzip2/null_except branch April 13, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants