Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with plib in Material #537

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Fixed bug with plib in Material #537

merged 6 commits into from
Sep 11, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Sep 9, 2024 •
edited
Loading

Description

This fixes a NoneType error in the syntax tree. This was due to the material parser freaking out and not being able to fully parse: plib=84p, namely it couldn't parse: \d+[a-z]+.

Fixes #521

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@MicahGale MicahGale linked an issue Sep 9, 2024 that may be closed by this pull request
Problem formatting material with "plib" for MCNP input #521
Closed
@MicahGale MicahGale self-assigned this Sep 9, 2024
@MicahGale MicahGale added bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". critical An issue that seriously limits user adoption or hampers current use. labels Sep 9, 2024
@MicahGale MicahGale marked this pull request as ready for review September 9, 2024 13:01
tjlaboss
tjlaboss requested changes Sep 11, 2024
View reviewed changes
montepy/input_parser/material_parser.py Show resolved Hide resolved
tests/inputs/test.imcnp Show resolved Hide resolved
tjlaboss
tjlaboss approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the known limitation to the documentation in a separate issue.

@MicahGale MicahGale mentioned this pull request Sep 11, 2024
Closed
@MicahGale MicahGale merged commit 7d3294d into develop Sep 11, 2024
15 checks passed
@MicahGale MicahGale deleted the 521-problem-formatting-material-with-plib-for-mcnp-input branch September 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". critical An issue that seriously limits user adoption or hampers current use.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem formatting material with "plib" for MCNP input
2 participants
@MicahGale @tjlaboss