[#112] Support for package management #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorobon
requested review from
dortegau,
blalop,
frantsao,
jmonterrubio,
jperera,
caldito and
Thasselhof
dortegau
reviewed
Jun 1, 2020
.idea/.gitignore
Outdated
| @@ -0,0 +1,8 @@ | |||
| # Default ignored files | |||
There was a problem hiding this comment.
This files under .idea/ directory should be removed, shouldn't be?
dortegau
reviewed
Jun 1, 2020
vars/main.yml
Outdated
| @@ -9,3 +9,6 @@ solr_cloud_url: "http://archive.apache.org/dist/lucene/solr/{{ solr_version }}/{ | |||
| solr_external_libraries_destination_path: "{{ solr_installation_dir }}/server/solr-webapp/webapp/WEB-INF/lib/" | |||
| solr_external_libraries_required_packages: | |||
| - python-lxml | |||
| solr_packages_libraries_required_packages: | |||
| - python-lxml | |||
There was a problem hiding this comment.
Seems that this package is installed because is referenced in L:13 under solr_packages_libraries_required_packages list variable
frantsao
approved these changes
Jun 1, 2020
jmonterrubio
approved these changes
Jun 2, 2020
caldito
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Support for Package Management in solr.
Possible Drawbacks
none
Applicable Issues
#120