Features/75 #76
Merged
Features/75 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorobon
requested review from
jmonterrubio,
dortegau,
frantsao,
jnogol and
jperera
and removed request for
jmonterrubio
dortegau
approved these changes
Jan 29, 2019
jnogol
approved these changes
Jan 29, 2019
jmonterrubio
approved these changes
Jan 29, 2019
dortegau
reviewed
Jan 29, 2019
templates/solr.in.sh.j2
Outdated
| # so you can point the script to use a different log4j.properties file | ||
| LOG4J_PROPS="/opt/solr/log4j.properties" | ||
| # so you can point the script to use a different log4j2.xml file | ||
| LOG4J_PROPS={{ {{ solr_installation_dir }} }}/{{ solr_log_config_file }} |
There was a problem hiding this comment.
seems that should be only with one level of braces :) {{ solr_installation_dir }}
There was a problem hiding this comment.
yes... you're right!
Changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Fixing #75
Benefits
Logging now works as intended.
Possible Drawbacks
I hope not :)
Applicable Issues
Fixing #75