Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to template, Rough beamer slide template #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Optimus-Pine
Copy link

Hello,

I made some additions to sample.tex. One demonstrates the addition of a footnote to a chapter heading, and the other shows how one can build a larger document in smaller components using subfile.

I also added a basic slide template I used for my defense.

Thank you for constructing this template! My document was accepted with only some minor revisions / text shuffling.

Best,
Sam

sample.tex Outdated
@@ -54,12 +54,18 @@

% graphics packages
\usepackage[pdftex]{graphicx} % remove pdftex if you are not compiling to pdf
\graphicspath{{./figures/}} % this places all graphics in the figures subdirectory
\graphicspath{{./figures/}{../figures/}} % this places all graphics in the figures subdirectory
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we adding ../figures/? I'm inclined not to do this (unless there is a reason I'm missing) because it will potentially include figures from a directory that is outside of this repo, which may cause some confusion.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this is another artifact of using subfiles across directories. When compiling components individually, the relative path is traced from the subfile and not from the main file.

sample.tex Outdated
% a copy of thesis.cls in that directory. There should be a way to fix this, but
% I was forced to move on before figuring it out.
\usepackage{subfiles}

Copy link
Owner

@idfah idfah Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little hesitant to include this for a few reasons:

  1. I think we would need to solve the problem of including the thesis.cls in the subdirectory, I would prefer not to have duplicate code
  2. Users can always look up this feature. Although it is nice to include useful things, there does have to be some limit because if we begin including too many things it may become confusing / cluttered. That said, it is always difficult to know where that line should be drawn. I'm open to hearing arguments as to why it should be included, but am leaning toward leaving this one out.
  3. This might be a bit much for a sample document?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another thought... in my dissertation I use something like this to include subfiles:

\input{intro.tex}
\input{background.tex}
\input{methods.tex}

although it doesn't allow things to be compiled individually, it does break things up while not depending on an additional package

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enjoy subfile because I frequently re-compile, and so the time savings adds up quickly for me. Given the messiness introduced by duplicating the thesis.cls file and the extra refactoring it would take to switch the template over to such a model, I think it makes sense to allow users to add this at their own discretion.

sample.tex Show resolved Hide resolved
sample.tex Outdated
@@ -188,17 +194,11 @@
\mainmatter % starts thesis body
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

\chapter{Introduction}
\chapter[Introduction]{Introduction\footnote{Here is an example of a citation in a chapter heading.}}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things about the grad school guidelines that I really don't like :) and this is one of them. I wonder when it would be necessary to actually put a citation in the heading of a chapter? I'm guessing this wouldn't be an actual BibTeX citation?

If we do include this, could we have an actual example, instead of just saying that this is an example? Also, it might be good to have a comment in the code explaining this situation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, silly me. I forgot the actual citation!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never had to cite an author in a section heading myself, but I did notice there was an open issue concerning this. The latest commit includes an example of this in the "Citation" section, which seemed more appropriate.

sample.tex Outdated

This package is free software and your are permitted to use, modify and distribute this software as you like. Please read \aref{appendix:license}, the file \textit{LICENSE} or the source code headers for a full copy of the license.
\subfile{./subfiles/introduction.tex} % Here is an example of including a chapter as a subfile.
%You can now edit and compile introduction.tex independently, saving some compile and scrolling time for large documents.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I really do like this usage of subfile, I'm just skeptical that it should be in the sample document?

% Be sure to practice before your talk :)
\documentclass{beamer}
\setbeameroption{show only notes}
\input{./sampleSlides.tex}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please submit a separate PR for your slides? I would be open to adding sample beamer slides, but I also have been working on some myself. If you create a separate PR I might try to merge it with what I have and get back to you on this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly. I was a little silly for this request and mixed too many commits together; let me start fresh and submit the PRs separately.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to create a separate pull request for the slides; I reverted my previous changes and re-committed the slides separately. Now that this request is open, it seems to be absorbing any new commits I make.

@idfah
Copy link
Owner

idfah commented Nov 1, 2018

@Optimus-Pine I have added some comments to your PR. Can you please look at them and share any thoughts you have?

@idfah idfah removed the question label Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants