Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest commits #4

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Latest commits #4

merged 2 commits into from
Apr 11, 2023

Conversation

joegilkes
Copy link
Contributor

Sorry, just realised I hadn't pushed my latest commits onto my fork so I missed them when I set up the PR earlier.

Just a couple of tweaks:

  • Added the automatic removal of spectator molecules from predicted reactions, which streamlines things down the line by simplifying the OpenBabel OBMols and therefore the intermediate SMILES strings, and therefore the creation of Morgan FPs. Spectators get removed by FP subtraction anyway so it doesn't change much, but streamlines radical canonicalisation a lot.
  • The output node activation function selection requires a hacky workaround to force its hand, because for some reason SKLearn makes it so it gets overriden to be a linear activation.

@idilismail idilismail merged commit d9312f7 into idilismail:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants