Cache GIDD exports using S3 #628
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: apps/gidd/views.py
Did you find this useful? React with a 👍 or 👎 |
thenav56
force-pushed
the
feature/cache-export
branch
3 times, most recently
from
c1a3ef9
to
b332143
Compare
tnagorra
reviewed
May 14, 2024
| DISAGGREGATION_EXPORT = 'disaggregation-export' | ||
| DISAGGREGATION_EXPORT_GEOJSON = 'disaggregation-export-geojson' | ||
| DISASTER_EXPORT = 'disaster-export' | ||
| DISPLACEMENT_EXPORT = 'displacement-export' |
There was a problem hiding this comment.
I also saw conflict-export in the gidd export.
We need to see if we also add them.
There was a problem hiding this comment.
Conflict-export is generated using filter by another export.
tnagorra
requested changes
May 14, 2024
apps/gidd/cache.py
Outdated
Comment on lines
45
to
51
| return ( | ||
| re.sub( | ||
| ' +', | ||
| ' ', | ||
| (StatusLog.last_release_date() or '').replace(',', ' ') | ||
| ) | ||
| ).replace(',', ' ').strip().replace(' ', '-') |
There was a problem hiding this comment.
Are we converting datetime to date?
| GiddExportCache.Key.DISAGGREGATION_EXPORT_GEOJSON, | ||
| lambda: self._export_disaggregated_geojson(filename, qs), | ||
| s3_parameters={ | ||
| 'ResponseContentDisposition': f'attachment; filename={filename}.geojson', |
There was a problem hiding this comment.
Don't we need the response content type here? or is json default content type?
There was a problem hiding this comment.
Done
NOTE: This is automatically handed by S3 as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Changes
This PR doesn't introduce any:
printThis PR contains valid: