Add management command to patch ahhs data. #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rup-Narayan-Rajbanshi
force-pushed
the
feature/fix-ahhs-data
branch
from
47c8391
to
f87a5ed
Compare
Rup-Narayan-Rajbanshi
force-pushed
the
feature/fix-ahhs-data
branch
from
f87a5ed
to
678fac9
Compare
Rup-Narayan-Rajbanshi
force-pushed
the
feature/fix-ahhs-data
branch
2 times, most recently
from
c99f349
to
7b0f4df
Compare
tnagorra
reviewed
Jun 4, 2024
|
|
||
| class Command(BaseCommand): | ||
|
|
||
| help = "Fix AHHS household size data." |
There was a problem hiding this comment.
Suggested change
| help = "Fix AHHS household size data." | |
| help = "Patch AHHS household size data." |
tnagorra
reviewed
Jun 4, 2024
Comment on lines
74
to
78
| logger.info("2024 AHHS data fixed successfully.") | ||
| except FileNotFoundError: | ||
| logger.error(f"CSV file at {csv_file_path} not found.") | ||
| except Exception: | ||
| logger.error("Failed to fix 2024 AHHS data:", exc_info=True) |
There was a problem hiding this comment.
Suggested change
| logger.info("2024 AHHS data fixed successfully.") | |
| except FileNotFoundError: | |
| logger.error(f"CSV file at {csv_file_path} not found.") | |
| except Exception: | |
| logger.error("Failed to fix 2024 AHHS data:", exc_info=True) | |
| logger.info("AHHS data patched successfully.") | |
| except FileNotFoundError: | |
| logger.error(f"CSV file at {csv_file_path} not found.") | |
| except Exception: | |
| logger.error("Failed to patch AHHS data:", exc_info=True) |
tnagorra
reviewed
Jun 4, 2024
Comment on lines
59
to
62
| self.stdout.write(f'Figure id not found ids: {figure_id_not_found}') | ||
| self.stdout.write(f'Figure unit not household ids: {change_in_unit_figures}') | ||
| self.stdout.write(f'Change in reported value figure ids: {change_in_reported_value_figures}') | ||
| self.stdout.write(f'No change in household size figure ids: {no_change_in_household_figures}') |
There was a problem hiding this comment.
Can we log these as error?
There was a problem hiding this comment.
Also, shouldn't we use logger?
tnagorra
reviewed
Jun 4, 2024
| self.stdout.write(f'Change in reported value figure ids: {change_in_reported_value_figures}') | ||
| self.stdout.write(f'No change in household size figure ids: {no_change_in_household_figures}') | ||
| self.stdout.write(f'Total number of figures patched: {len(patched_figure_ids)}') | ||
| self.stdout.write(f'Figure Ids patched with old household and total figures: {patched_figure_ids}') |
There was a problem hiding this comment.
Suggested change
| self.stdout.write(f'Figure Ids patched with old household and total figures: {patched_figure_ids}') | |
| self.stdout.write(f'IDs of figures patched: {patched_figure_ids}') |
Rup-Narayan-Rajbanshi
force-pushed
the
feature/fix-ahhs-data
branch
from
7b0f4df
to
9ea7621
Compare
thenav56
requested changes
Jun 4, 2024
thenav56
reviewed
Jun 4, 2024
Rup-Narayan-Rajbanshi
force-pushed
the
feature/fix-ahhs-data
branch
from
9ea7621
to
148fb11
Compare
tnagorra
reviewed
Jun 4, 2024
Comment on lines
77
to
76
| self.stdout.write(f"Total number of figures patched: {len(patched_figure_ids)}") | ||
| self.stdout.write(f"IDs of figures patched: {patched_figure_ids}") |
There was a problem hiding this comment.
This does not have any information.
tnagorra
force-pushed
the
feature/fix-ahhs-data
branch
2 times, most recently
from
cd88c9c
to
1459fb2
Compare
thenav56
previously approved these changes
Jun 5, 2024
tnagorra
force-pushed
the
feature/fix-ahhs-data
branch
from
1459fb2
to
5c4087c
Compare
- Additionally log bulk update summary
tnagorra
force-pushed
the
feature/fix-ahhs-data
branch
from
5c4087c
to
48d2693
Compare
thenav56
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Changes
This PR doesn't introduce any:
printThis PR contains valid:
CSV File
manually_updated_ahhs_figures_mar_13.csv