Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart the idris compiler after every commmand if it was killed #54

Merged
merged 5 commits into from
Sep 18, 2015

Conversation

archaeron
Copy link
Member

No description provided.

@archaeron
Copy link
Member Author

according to the node documentation there is a connectedproperty on the process (https://nodejs.org/api/child_process.html#child_process_child_connected)
but the property always returns false for me, even after just having spawned the process

@archaeron
Copy link
Member Author

@jeremy-w could you take a look at this?

@process.on 'error', @error
@process.on 'exit', @exited
@process.on 'close', @exited
@process.on 'disconnect', @exited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like, in place of the connected property that wasn't working for you, you're watching for the process to die via all the various events?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connected property is a bool that should tell if it's connected right now (at least according to the docs). I use killed now to check if the compiler is running, and only start a new instance if it's not.
The events are used if the compiler crashes or is killed by the user.

@archaeron archaeron changed the title [WIP] restart the idris compiler after every commmand if it was killed Restart the idris compiler after every commmand if it was killed Sep 16, 2015
archaeron added a commit that referenced this pull request Sep 18, 2015
Restart the idris compiler after every commmand if it was killed
@archaeron archaeron merged commit 1c306ee into master Sep 18, 2015
@archaeron archaeron deleted the issue-51 branch September 18, 2015 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants