Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some "verified" implementations #4848

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add some "verified" implementations #4848

wants to merge 11 commits into from

Commits on May 24, 2020

  1. Move Verified implementations to new file 

    This way a module can import Verified without importing
implementations, avoiding circular dependencies in some cases.

It would be nicer to put the implementations in with their types.
    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    a986736 View commit details
    Browse the repository at this point in the history

  2. Add some verified implementations

    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    2f1610e View commit details
    Browse the repository at this point in the history

  3. Add Complex implementations

    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    4b4ac82 View commit details
    Browse the repository at this point in the history

  4. Cut useless implementation labels

    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    be6621e View commit details
    Browse the repository at this point in the history

  5. Implement interfaces for Sign

    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    33bbca4 View commit details
    Browse the repository at this point in the history

  6. Move verified algebra interfaces to Control.Algebra 

    I was running into some weird import issues, and this seems to solve
them. Interfaces.Verified as a module probably ought to be abolished,
as it really isn't very useful as a grouping.
    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    c0392c9 View commit details
    Browse the repository at this point in the history

  7. Add GroupHomomorphism

    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    d5475b4 View commit details
    Browse the repository at this point in the history

  8. Add CyclicGroup 

    Every cyclic group is abelian, so also replace AbelianGroup
implementations with CyclicGroup implementations where possible.
    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    8872ba4 View commit details
    Browse the repository at this point in the history

  9. Make all abelian groups verified 

    AbelianGroup doesn't add anything syntactically, so there really isn't
any point to maintaining the plain / verified split.
    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    602c5d2 View commit details
    Browse the repository at this point in the history

  10. Add direct product implementations

    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    feedb9a View commit details
    Browse the repository at this point in the history

  11. Add neutral product laws

    @nickdrozd
    nickdrozd committed May 24, 2020
    Configuration menu
    Copy the full SHA
    0fd6d50 View commit details
    Browse the repository at this point in the history