Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected issue as pointed out by SonarQube #2

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Corrected issue as pointed out by SonarQube #2

merged 2 commits into from
Aug 18, 2021

Conversation

JacobIDR
Copy link

No description provided.

KieranFrance
KieranFrance reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@KieranFrance KieranFrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you update the PR to merge with Develop instead of Master

@JacobIDR JacobIDR changed the base branch from master to develop August 17, 2021 07:50
@JacobIDR JacobIDR merged commit 0b65d74 into develop Aug 18, 2021
@daniel-warren daniel-warren deleted the SonarQube-Correction branch December 21, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranFrance KieranFrance KieranFrance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JacobIDR @KieranFrance @Amy1612 @jtljac