Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Api Version #30

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

Updated the Api Version #30

wants to merge 1 commit into from

Conversation

eziel
Copy link

@eziel eziel commented Jul 23, 2013

No description provided.

@@ -10,7 +10,7 @@ var INVITE_URL = "http://bit.ly/clMDW5";

// javascript's RegExp \w character class doesn't include common extended characters. this string
// includes some common latin characters, at least.
var wordchars = '\\w�������������������������������������������������������������';
var wordchars = '\\w���������������������������������������������������������������';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here? I can't get a clean diff on this line. Character encoding difference maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loaded up some bytes w/ python, here's the diff:

>>> orig
"wordchars = '\\\\w\xc0\xc8\xcc\xd2\xd9\xe0\xe8\xec\xf2\xf9\xc1\xc9\xcd\xd3\xda\xdd\xe1\xe9\xed\xf3\xfa\xfd\xc2\xca\xce\xd4\xdb\xe2\xea\xee\xf4\xfb\xc3\xd1\xd5\xe3\xf1\xf5\xc4\xcb\xcf\xd6\xdc\xe4\xeb\xef\xf6\xfc\xa1\xbf\xe7\xc7\xdf\xd8\xf8\xc5\xe5\xc6\xe6\xde\xfe\xd0\xf0';"
>>> new
"wordchars = '\\\\w\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd\xef\xbf\xbd';"

So all the characters were replaced with unicode replacement characters from the looks of things. Probably best to do something like:

git reset --soft HEAD~1
git reset .
git add -p
# ignore first hunk, add second
git commit
# commit message...
git push -f origin patch-1

A better / long-term solution would be to use unicode escape codes instead of the actual glyphs in this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants