Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch_accumulator bug when rolling to new segment #1318

Closed
wants to merge 10 commits into from

Conversation

numinnex
Copy link
Contributor

@numinnex numinnex commented Nov 1, 2024

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Nov 1, 2024

Pull Request Test Coverage Report for Build 11654303199

Details

  • 65 of 70 (92.86%) changed or added relevant lines in 18 files are covered.
  • 36 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.006%) to 75.129%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/src/channels/commands/maintain_messages.rs 0 1 0.0%
server/src/compat/storage_conversion/persistency/partitions.rs 0 1 0.0%
server/src/streaming/partitions/messages.rs 13 16 81.25%
Files with Coverage Reduction New Missed Lines %
server/src/streaming/systems/messages.rs 1 69.7%
sdk/src/http/client.rs 1 73.63%
server/src/configs/config_provider.rs 1 84.54%
server/src/streaming/systems/users.rs 1 88.15%
server/src/streaming/batching/batch_accumulator.rs 14 69.51%
server/src/streaming/segments/messages.rs 18 70.0%
Totals Coverage Status
Change from base Build 11653741388: -0.006%
Covered Lines: 23072
Relevant Lines: 30710

💛 - Coveralls

@numinnex numinnex force-pushed the fix_accumulator_for_new_segment branch 2 times, most recently from bb1d040 to 6549656 Compare November 3, 2024 19:05
@numinnex numinnex force-pushed the fix_accumulator_for_new_segment branch from 6549656 to f2fa5e3 Compare November 3, 2024 20:06
@numinnex numinnex closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants