Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the github action for tests #1028

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Update the github action for tests #1028

merged 2 commits into from
Jul 18, 2023

Conversation

Waelthus
Copy link
Contributor

This updates the test github action to use python 3.9 - 3.11 to make sure we actually test on recent versions

@Waelthus
Copy link
Contributor Author

This also needed to update iminuit to more recent versions as the old version we pinned is unavailable for newer python.
Given that we're not using the fitter2 anymore, the previously required pinning might now be unnecessary.
If we want to support specific versions (e.g. 3.8) forever, we should run the tests on those as well

@Waelthus Waelthus requested a review from iprafols July 17, 2023 19:34
@Waelthus Waelthus marked this pull request as ready for review July 17, 2023 19:34
@iprafols iprafols added this pull request to the merge queue Jul 18, 2023
Merged via the queue into master with commit 6ed0707 Jul 18, 2023
8 checks passed
@iprafols iprafols deleted the update-python-test-version branch July 18, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iprafols iprafols iprafols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Waelthus @iprafols