Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new option per_r_par for covariance smoothing #1030

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

julienguy
Copy link
Contributor

  • add option per_r_par to picca.utils.smooth_cov
    if per_r_par=True (False by default), the correlation coefficients are averaged per (rpar,delta_rpar,delta_rperp) and not per (delta_rpar,delta_rperp).
  • add option --smooth-per-r-par to picca_export.py

This is useful for some correlation functions where the default scheme is not accurate and can lead to non positive matrices.
For instance SIV and CIV side bands auto-correlations, or the lyb x lya cross-correlation.

Example:

# default (non positive output matrix)
picca_export.py --data /global/cfs/cdirs/desicollab/science/lya/y1-kp6/iron-tests/correlations/correlation-lyalyb-1-0-0/cf_lya_x_lyb.fits --out cf_lya_x_lyb_exp.fits --blind-corr-type lyaxlyb

# with new option (positive output matrix)
picca_export.py --data /global/cfs/cdirs/desicollab/science/lya/y1-kp6/iron-tests/correlations/correlation-lyalyb-1-0-0/cf_lya_x_lyb.fits --out cf_lya_x_lyb_exp_bis.fits --blind-corr-type lyaxlyb --smooth-per-r-par

Copy link
Collaborator

@iprafols iprafols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of minor suggestions

py/picca/utils.py Outdated Show resolved Hide resolved
py/picca/utils.py Outdated Show resolved Hide resolved
@julienguy
Copy link
Contributor Author

done

@iprafols iprafols added this pull request to the merge queue Jul 28, 2023
Merged via the queue into master with commit d0760a7 Jul 28, 2023
8 checks passed
@iprafols iprafols deleted the covmat-smoothing-option branch July 28, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants