-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old picca routines [bump major] #1033
Conversation
It's expected that code testing coverage will change, I'll use that as a hint regarding which parts may be removable e.g. in picca/{io.py,prep_del.py,...} |
io.py will definitely not be removable since it is also used for the computation of the correlation function. Maybe for now we can just remove picca_deltas.py and the tests associated with it. We might as well remove the fitter2 now that we're on this. We have also been using Vega for a while now |
yes, I know that it won't be fully removable, but the other files regarding deltas will be. And for io I'd at least remove a bunch of spectra-read-in (read_data, read_from...) functions, but will keep deltas/objects/dlas/absorbers/drq alive. |
fitter2 is already removed here |
cool, makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, I see that you did not remove the bits of code from io.py and the rest. Maybe you can also remove the fitter2 folder
This reverts commit 4335dd1.
Most legacy code that isn't used by for cf et al is gone. Parts of data.Forest are still there as cf hijacks it's variables, prep_del is only kept for stacking, raw_io is kept in case it's still needed (as we don't test it afaik). Which version do we want? 8.0 as this is breaking all bw compatibility to old picca? |
I'd say to go to version 8, yes. It does make sense to keep the raw analysis for the meantime (maybe we should try to migrate it to be part of the delta_extraction code at some point. Also, I totally agree on having tests for the missing parts. I see that the test suit has changed. Was this needed due to the library changes that made the tests fail? |
Ah, I originally thought I could remove everything related to picca_deltas tests. Just to figure out later that those files were partially inputs of the cf and p1d tests, so one commit needed partial revert...
In the end it should be removals of files and code only (and changing some comments).
Am 1. August 2023 17:25:08 MESZ schrieb "Ignasi Pérez-Ràfols" ***@***.***>:
…I'd say to go to version 8, yes. It does make sense to keep the raw analysis for the meantime (maybe we should try to migrate it to be part of the delta_extraction code at some point. Also, I totally agree on having tests for the missing parts.
I see that the test suit has changed. Was this needed due to the library changes that made the tests fail?
--
Reply to this email directly or view it on GitHub:
#1033 (comment)
You are receiving this because you were assigned.
Message ID: ***@***.***>
|
closes #1032 |
This PR intends to remove old picca routines, such as picca_deltas and picca_fitter2 with their dependencies (but leaving the parts that correlation function and p1d still need). Adresses #1032