Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to config #1035

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Add version to config #1035

merged 3 commits into from
Aug 2, 2023

Conversation

cramirezpe
Copy link
Contributor

For those who install picca through pip, git hash is not possible to get.

Having the version printed in the config file won't be perfect, but it is better than nothing.

@Waelthus
Copy link
Contributor

Waelthus commented Aug 2, 2023

given that a version is equivalent to a git hash for pip install picca this sounds like a good idea. And for people running on their own branches this should give both the latest master version and the commit hash which makes things clearer as well.

@iprafols: I guess we'll need to include the test_file to the version updating and exempt it from triggering the version bumping action, I'll merge master into here to check

@Waelthus
Copy link
Contributor

Waelthus commented Aug 2, 2023

or rather there shouldn't be an issue, as we don't check if the results actually match (which would be impossible for the timestamp at least)

@Waelthus Waelthus added this pull request to the merge queue Aug 2, 2023
Merged via the queue into master with commit aaa6d62 Aug 2, 2023
8 checks passed
@Waelthus Waelthus deleted the add_version_to_config branch February 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants