added fast-metals option to picca_metal_dmat [minor] #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iprafols
requested changes
Sep 4, 2023
iprafols
requested changes
Sep 5, 2023
bin/picca_metal_dmat.py
Outdated
| @@ -313,6 +313,9 @@ def main(cmdargs): | |||
| cf.alpha_abs[args.lambda_abs] = cf.alpha | |||
| for metal in args.abs_igm: | |||
| cf.alpha_abs[metal] = args.metal_alpha | |||
|
|
|||
| #store the default silicon metals modelled in the CF/XCF | |||
| DEFAULT_SI_METALS = ['SiIII(1207)','SiII(1190)','SiII(1193)','SiII(1260)'] | |||
There was a problem hiding this comment.
This should be placed at the top of the file, in line 20
|
also note that the tests are failing now |
added 2 commits
September 5, 2023 02:18
iprafols
approved these changes
Sep 5, 2023
iprafols
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling this option only computes the relevant 4 LYA x Si and CIVxCIV.